2849 adds cupy to the testing environment #2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
7 tasks
rijobro
approved these changes
Aug 27, 2021
Contributor
rijobro
left a comment
rijobro
left a comment
There was a problem hiding this comment.
Looks great. We'll have to check through the logs to confirm that optional_import("cupy") is working and therefore the cupy unit tests are being performed. An easy place to check is test_to_cupy.py.
Contributor
Author
sure, this is now tested, verified by the log https://github.com/Project-MONAI/MONAI/runs/3443271494?check_suite_focus=true (and the coverage report) |
wyli
added a commit
to Borda/MONAI
that referenced
this pull request
Aug 27, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
part of #2849
Description
enable cupy in one of the gpu testing pipelines
Status
Ready
Types of changes