Split On Grid #2879
Merged
Split On Grid #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Nic-Ma
reviewed
Sep 2, 2021
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Member
Author
|
@Nic-Ma, this PR is ready with all the changes that you suggested. Thanks |
Nic-Ma
reviewed
Sep 3, 2021
Nic-Ma
reviewed
Sep 3, 2021
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Member
Author
|
@Nic-Ma I made some changes. Can you check if it's what you had in mind for thread safety. Thanks |
wyli
pushed a commit
to Borda/MONAI
that referenced
this pull request
Sep 6, 2021
* Implement SplitOnGrid Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Implement dictionary-based SplitOnGrid Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update inits Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Change imports Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update input logic in SplitOnGrid) Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add unittests for SplitOnGrid and SplitOnGridDict Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Sort import Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Remove imports Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Address comments Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Remove optional Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Address thread safety issues Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One part of digital pathology pipeline is to split the extracted region/patch into sub-patches on a grid (for instance 3x3). This PR implement
SplitOnGridto enable that for 2D histopathology images.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.