-
Notifications
You must be signed in to change notification settings - Fork 1.4k
3296 adds a flag for invertible on/off, and decouples transform stack API #3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55751a4 to
fcff4f0
Compare
Member
|
This looks like a good change but @rijobro should certainly look over it. |
f17a5a0 to
acfbfbd
Compare
Contributor
Author
Nic-Ma
reviewed
Nov 11, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
f06ebf3 to
e098676
Compare
55da427 to
9b76442
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
9b76442 to
668e01b
Compare
Nic-Ma
approved these changes
Nov 12, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
Author
|
/build |
Contributor
|
Looks great, thanks for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #3296
Description
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.