Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Nov 9, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3296

Description

  • adds a flag so that we can completely turn off the transform stack
  • decouples the APIs for maintaining the transform stack

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro November 9, 2021 23:15
@wyli wyli changed the title adds a flag for invertible on/off, and decouples transform stack APi 3296 adds a flag for invertible on/off, and decouples transform stack APi Nov 9, 2021
@wyli wyli force-pushed the flag-for-invertible branch from 55751a4 to fcff4f0 Compare November 10, 2021 12:08
@wyli wyli changed the title 3296 adds a flag for invertible on/off, and decouples transform stack APi 3296 adds a flag for invertible on/off, and decouples transform stack API Nov 10, 2021
@ericspod
Copy link
Member

This looks like a good change but @rijobro should certainly look over it.

@wyli wyli marked this pull request as ready for review November 10, 2021 15:03
@wyli wyli force-pushed the flag-for-invertible branch from f17a5a0 to acfbfbd Compare November 10, 2021 15:17
@wyli
Copy link
Contributor Author

wyli commented Nov 11, 2021

This looks like a good change but @rijobro should certainly look over it.

He is on annual leave, could you please help review @Nic-Ma @ericspod? I'm revising this for the upcoming release in November.

wyli added 4 commits November 11, 2021 18:34
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the flag-for-invertible branch from f06ebf3 to e098676 Compare November 11, 2021 18:46
@wyli wyli requested a review from Nic-Ma November 11, 2021 18:46
@wyli wyli force-pushed the flag-for-invertible branch from 55da427 to 9b76442 Compare November 11, 2021 18:59
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the flag-for-invertible branch from 9b76442 to 668e01b Compare November 11, 2021 19:01
@wyli
Copy link
Contributor Author

wyli commented Nov 12, 2021

/build

@wyli wyli merged commit d35759a into Project-MONAI:dev Nov 12, 2021
@wyli wyli deleted the flag-for-invertible branch November 12, 2021 09:31
@rijobro
Copy link
Contributor

rijobro commented Nov 15, 2021

Looks great, thanks for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decouple the transform stack API from InvertibleTransforms?

4 participants