Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jan 27, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3723

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro January 27, 2022 14:15
@wyli wyli changed the title update bbox docstring 3723 update bbox docstring Jan 27, 2022
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change, the first word of the docstring should be "Generate" also.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3723-docstring-bbox branch from 5281b3c to 7d11f8f Compare January 27, 2022 17:51
@wyli
Copy link
Contributor Author

wyli commented Jan 27, 2022

/build

@wyli wyli enabled auto-merge (squash) January 27, 2022 17:52
@wyli wyli merged commit b1a96c5 into Project-MONAI:dev Jan 27, 2022
wyli added a commit that referenced this pull request Feb 9, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli deleted the 3723-docstring-bbox branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate_spatial_bounding_box looses first dimension

2 participants