Skip to content

3725 fixes download test #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2022
Merged

3725 fixes download test #3728

merged 3 commits into from
Jan 28, 2022

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jan 27, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3725

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from Nic-Ma January 27, 2022 14:46
@wyli
fixes test
56076e0 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3725-download-issue branch from 3ead86c to 56076e0 Compare January 27, 2022 23:28
@wyli
Copy link
Contributor Author

wyli commented Jan 27, 2022 •
edited
Loading

/integration-test

@wyli wyli force-pushed the 3725-download-issue branch from 8d700ea to 8172d6a Compare January 27, 2022 23:48
Nic-Ma
Nic-Ma approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Is it PR ready for review now? I saw you updated a lot after requesting review.
But it overall looks good to me.
Add @ericspod and @rijobro to double confirm the contextmanager as you guys are python feature experts.

Thanks for the enhancement.

@Nic-Ma Nic-Ma requested review from ericspod and rijobro January 28, 2022 02:25
@wyli
Copy link
Contributor Author

wyli commented Jan 28, 2022

/build

@wyli
skip when downloading fails
803bf06 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3725-download-issue branch from 4a5b8aa to 803bf06 Compare January 28, 2022 09:21
@wyli
Copy link
Contributor Author

wyli commented Jan 28, 2022

/build

@wyli wyli enabled auto-merge (squash) January 28, 2022 09:24
@wyli wyli merged commit db61a08 into Project-MONAI:dev Jan 28, 2022
wyli added a commit that referenced this pull request Feb 9, 2022
@wyli
3725 fixes download test (#3728)
d27ab6c 
* fixes test

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* skip when downloading fails

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli deleted the 3725-download-issue branch June 11, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

nightly test: tests.test_download_and_extract

2 participants

@wyli @Nic-Ma