3765 Enhance `create_multigpu_supervised_XXX` for distributed#3768

Merged

Nic-Ma merged 8 commits intoProject-MONAI:devfrom

Nic-Ma:3765-fix-create-multigpu-trainer

Feb 4, 2022

Contributor

Nic-Ma commented Feb 4, 2022

Fixes #3765 .

Description

This PR enhanced create_multigpu_supervised_trainer for devices when distributed=True, and added distributed tests.

Status

Ready

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 6 commits

February 1, 2021 19:15


          Merge pull request #19 from Project-MONAI/master

42a45e0

merge master


          Merge pull request #32 from Project-MONAI/master

cd16a13

merge master


          Merge pull request #180 from Project-MONAI/dev

6f87afd

merge master


          Merge pull request #214 from Project-MONAI/dev

f398298

merge master


          Merge pull request #366 from Project-MONAI/dev

d06af47

merge master


          [DLMED] add check for devices

541c404

Signed-off-by: Nic Ma <nma@nvidia.com>

Nic-Ma changed the title ~~3765 Enhance create_multigpu_supervised_trainer for distributed~~ 3765 Enhance create_multigpu_supervised_XXX for distributed


          Merge branch 'dev' into 3765-fix-create-multigpu-trainer

64193e2

Contributor Author

Nic-Ma commented Feb 4, 2022

/black

Contributor Author

Nic-Ma commented Feb 4, 2022

/build

Nic-Ma requested review from ericspod, rijobro and wyli

February 4, 2022 16:01

wyli reviewed

View reviewed changes

tests/test_parallel_execution_dist.py

wyli approved these changes

View reviewed changes

Contributor

wyli left a comment

Thanks, it looks good to me.


          [DLMED] update according to comments

7911cef

Signed-off-by: Nic Ma <nma@nvidia.com>

Contributor Author

Nic-Ma commented Feb 4, 2022

/black

Contributor Author

Nic-Ma commented Feb 4, 2022

/build

Nic-Ma merged commit 62b3f6e into Project-MONAI:dev

wyli pushed a commit to wyli/MONAI that referenced this pull request


          3765 Enhance create_multigpu_supervised_XXX for distributed (Projec…

f49a092

…t-MONAI#3768)

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

wyli added a commit that referenced this pull request


          3595 3766 adds a base writer and an itk writer (#3674)

afcf593

* temp spatial_resample

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes resampling

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes precisions

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update dict version

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes unit tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds docs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* copy grid for resampling

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes unit tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove normalize coordinates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* try to fix #3621 (#3673)

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typing

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes grid_sample, interpolate URLs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* simplify norm_coords

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update moveaxis

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* spatial sample tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* additional tests spatial resample

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* test invert saptial resample

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds a base writer and an itk writer

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove return self

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds reorient_spatial_axes

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes unit tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* sync 3701

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* try to fix #3766

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise docstring to be concise

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 3765 Enhance `create_multigpu_supervised_XXX` for distributed (#3768)

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* update to support dynamic spatial_size

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

wyli added a commit that referenced this pull request


          3595 Adds nibabel/pil writers (#3772)

4d0baa0

* temp spatial_resample

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes resampling

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes precisions

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update dict version

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes unit tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds docs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* copy grid for resampling

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes unit tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove normalize coordinates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* try to fix #3621 (#3673)

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typing

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes grid_sample, interpolate URLs

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* simplify norm_coords

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update moveaxis

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* spatial sample tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* additional tests spatial resample

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* test invert saptial resample

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds a base writer and an itk writer

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove return self

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds reorient_spatial_axes

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes unit tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* sync 3701

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* try to fix #3766

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* revise docstring to be concise

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 3765 Enhance `create_multigpu_supervised_XXX` for distributed (#3768)

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* update to support dynamic spatial_size

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds nibabel pil writers

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove unused ignore

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

wyli pushed a commit that referenced this pull request


          3765 Enhance create_multigpu_supervised_XXX for distributed (#3768)

b781b96

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

wyli pushed a commit that referenced this pull request


          3765 Enhance create_multigpu_supervised_XXX for distributed (#3768)

1a979c4

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

wyli pushed a commit that referenced this pull request


          3765 Enhance create_multigpu_supervised_XXX for distributed (#3768)

10f52ab

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

wyli pushed a commit that referenced this pull request


          3765 Enhance create_multigpu_supervised_XXX for distributed (#3768)

227bad0

* [DLMED] add check for devices

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet