3938 enhance milmodel for torchscript#3939
Draft
yiheng-wang-nv wants to merge 8 commits intoProject-MONAI:devfrom
Draft
3938 enhance milmodel for torchscript#3939yiheng-wang-nv wants to merge 8 commits intoProject-MONAI:devfrom
yiheng-wang-nv wants to merge 8 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Collaborator
|
this looks good, but shouldn't we support all modes? |
Contributor
Author
Hi @myron , sure. To support |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
commented
Mar 23, 2022
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…-nv/MONAI into 3938-enhance-milmodel-for-ts
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Contributor
Author
|
Hi @myron , to support |
Contributor
Author
|
/black |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang vennw@nvidia.com
Fixes #3938 .
Description
With the changes,
MILModelwill support torchscript for allmil_mode.Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.