Skip to content

Conversation

@a-parida12
Copy link
Contributor

@a-parida12 a-parida12 commented Sep 14, 2022

Fixes #5148 .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor

wyli commented Sep 14, 2022

Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
@a-parida12 a-parida12 force-pushed the access-SAB-block-bias branch from 55a2e24 to a26e0e4 Compare September 14, 2022 20:47
@wyli
Copy link
Contributor

wyli commented Sep 14, 2022

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@wyli
Copy link
Contributor

wyli commented Sep 14, 2022

/build

@wyli wyli enabled auto-merge (squash) September 14, 2022 22:00
@wyli wyli merged commit 57d4609 into Project-MONAI:dev Sep 14, 2022
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Fixes #5148 .


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: a-parida12 <abhijeet.parida@tum.de>
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@a-parida12 a-parida12 deleted the access-SAB-block-bias branch April 5, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Set the bias term for the QKV linear layer in SAB

3 participants