Skip to content

replace view with reshape for robustness#5690

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
Joeycho:dev
Dec 8, 2022
Merged

replace view with reshape for robustness#5690
wyli merged 1 commit intoProject-MONAI:devfrom
Joeycho:dev

Conversation

@Joeycho
Copy link
Copy Markdown
Contributor

@Joeycho Joeycho commented Dec 8, 2022

#5684 (comment)
Signed-off-by: Joeycho joeyadamcho@gmail.com

Fixes #5684

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Project-MONAI#5684 (comment)
Signed-off-by: Joeycho <joeyadamcho@gmail.com>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Dec 8, 2022

/build

@wyli wyli enabled auto-merge (squash) December 8, 2022 15:55
@wyli wyli merged commit 25130db into Project-MONAI:dev Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use reshape over view? any benefit to keep using view over reshape?

2 participants