Skip to content

fixes discussion #5678 suppress_invalid_tags and other typos#5721

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:error-tag
Dec 13, 2022
Merged

fixes discussion #5678 suppress_invalid_tags and other typos#5721
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:error-tag

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Dec 13, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

fixes #5678
fixes #5724
fixes #5725

according to https://pydicom.github.io/pydicom/stable/reference/generated/pydicom.dataset.Dataset.html#pydicom.dataset.Dataset.to_json_dict

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli and others added 2 commits December 13, 2022 14:04
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli and others added 3 commits December 13, 2022 14:45
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Dec 13, 2022

/build

@wyli wyli enabled auto-merge (squash) December 13, 2022 15:58
@wyli wyli changed the title fixes discussion #5678 suppress_invalid_tags fixes discussion #5678 suppress_invalid_tags and other typos Dec 13, 2022
@wyli wyli merged commit 5200cc6 into Project-MONAI:dev Dec 13, 2022
@wyli wyli deleted the error-tag branch December 13, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename apply_gaussion to apply_gaussian rename regist_class to register_class

2 participants