5991 Enable lazy resampling for SpatialResample #6060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
yiheng-wang-nv
commented
Feb 24, 2023
yiheng-wang-nv
requested review from
KumoLiu,
Nic-Ma and
wyli
and removed request for
wyli
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…nsforms Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
approved these changes
Feb 24, 2023
wyli
reviewed
Feb 24, 2023
Nic-Ma
approved these changes
Feb 24, 2023
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me.
Just curious the difference between torch.float64 and torch.double, others places use torch.float64, why use torch.double in this PR?
Thanks.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #5991 .
Description
This PR adds the changes of
SpatialResamplefrom #5860 .Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.