Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Mar 16, 2023

  • mostly from @myron's implementation
  • remove is_binary_tensor checks, they are too expensive.
  • remove the deprecated compute_meandice (use compute_dice instead)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 4 commits March 16, 2023 22:29
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 2 commits March 16, 2023 23:56
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from KumoLiu and ericspod March 17, 2023 14:50
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the adds-dice-helper branch from e0c1a1c to ecebe4c Compare March 17, 2023 17:15
@wyli
Copy link
Contributor Author

wyli commented Mar 17, 2023

/build

@wyli wyli enabled auto-merge (squash) March 17, 2023 17:16
@wyli
Copy link
Contributor Author

wyli commented Mar 17, 2023

/build

@wyli wyli merged commit 5ce8a10 into Project-MONAI:dev Mar 17, 2023
@wyli wyli deleted the adds-dice-helper branch March 17, 2023 21:45
@myron
Copy link
Collaborator

myron commented Mar 18, 2023

Thank you for adding it, looks very good.
One small comment here
https://github.com/Project-MONAI/MONAI/blob/dev/monai/metrics/meandice.py#L206-L208

if we reach the last "return" statement, it seems to be guaranteed to be 0, so we don't need to calculate it

@wyli wyli mentioned this pull request Mar 18, 2023
@myron myron mentioned this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants