Fixed issues in nnunetv2runner#6470
Merged
wyli merged 16 commits intoProject-MONAI:devfrom May 7, 2023
Merged
Conversation
for more information, see https://pre-commit.ci
…MONAI into fix_nnunetv2runner
mingxin-zheng
approved these changes
May 6, 2023
Contributor
|
Hi @wyli , can you please also take a look in the updated APIs for nnunet? Thanks! |
wyli
approved these changes
May 6, 2023
Contributor
|
/build |
Contributor
|
@dongyang0122 there is a flake8 issue. Can you fix that thanks! |
Contributor
|
/build |
3 tasks
wyli
pushed a commit
that referenced
this pull request
May 10, 2023
Fixes #6496 . ### Description Fix the test after nnunet API change in #6470 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] In-line docstrings updated. --------- Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues in nnunetv2runner
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.