Add more unit tests #483
Merged
Add more unit tests #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pathology_nuclei_segmentation_classification` Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
`endoscopic_tool_segmentation_dist` Signed-off-by: KumoLiu <yunl@nvidia.com>
`endoscopic_tool_segmentation` Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
`wholeBody_ct_segmentation` Signed-off-by: KumoLiu <yunl@nvidia.com>
… add-unittests
pathology_nuclei_classification Signed-off-by: KumoLiu <yunl@nvidia.com>
… add-unittests
pathology_nuclick_annotation Signed-off-by: KumoLiu <yunl@nvidia.com>
lung_nodule_ct_detection Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Collaborator
|
/build |
wyli
approved these changes
Aug 28, 2023
Collaborator
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me. cc @yiheng-wang-nv please help confirm..
yiheng-wang-nv
approved these changes
Aug 29, 2023
Collaborator
|
Thanks @KumoLiu , could you also temporarily modify bundles that added unit tests in order to trigger the tests? |
Signed-off-by: KumoLiu <yunl@nvidia.com>
Collaborator
|
can refer to: |
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Collaborator
|
need sometime to figure how to solve the resource issue of github action. |
Collaborator
Author
I will help take a look at this one. |
This reverts commit 9b4b43d.
Collaborator
|
/build |
pathology_nuclei_segmentation_classification Signed-off-by: KumoLiu <yunl@nvidia.com>
Collaborator
|
/build |
Signed-off-by: KumoLiu <yunl@nvidia.com>
…into add-unittests
Collaborator
|
/build |
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
This reverts commit 3ee1b48.
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Collaborator
|
/build |
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Collaborator
|
/build |
yiheng-wang-nv
added a commit
to yiheng-wang-nv/model-zoo
that referenced
this pull request
Jul 29, 2024
Fixes # . ### Description This PR is used to add unit tests on the following bundles: - [x] endoscopic_tool_segmentation - [x] pathology_nuclei_segmentation_classification - [x] wholeBody_ct_segmentation - [x] pathology_nuclei_classification - [x] pathology_nuclick_annotation - [x] lung_nodule_ct_detection ### Status **Ready/Work in progress/Hold** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: KumoLiu <yunl@nvidia.com> Signed-off-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
This PR is used to add unit tests on the following bundles:
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").