Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Aug 11, 2022

Description

Fixes #102.

Updates documentation for HL7 support.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the documentation Improvements or additions to documentation label Aug 11, 2022
@mocsharp mocsharp added this to the 0.3.0 milestone Aug 11, 2022
@mocsharp mocsharp self-assigned this Aug 11, 2022
@mocsharp mocsharp changed the base branch from develop to vchang/102-hl7-store-message August 11, 2022 00:06
@mocsharp mocsharp force-pushed the vchang/102-update-docs-hl7 branch from 275ded0 to d7a3c4e Compare August 11, 2022 00:09
Base automatically changed from vchang/102-hl7-store-message to develop August 15, 2022 17:46
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/102-update-docs-hl7 branch from 4f0caa6 to 252c216 Compare August 15, 2022 17:53
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #114 (0843c8b) into develop (2bda3cb) will decrease coverage by 0.00715%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #114         +/-   ##
===================================================
- Coverage   92.88727%   92.88012%   -0.00715%     
===================================================
  Files            247         247                 
  Lines          13989       13989                 
  Branches         740         740                 
===================================================
- Hits           12994       12993          -1     
  Misses           778         778                 
- Partials         217         218          +1     
Flag Coverage Δ
unittests 92.88012% <ø> (-0.00715%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...maticsGateway/Services/HealthLevel7/MllpService.cs 78.04878% <0.00000%> (-2.43902%) ⬇️
...Gateway/Repositories/InferenceRequestRepository.cs 95.23810% <0.00000%> (+1.19048%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bda3cb...0843c8b. Read the comment docs.

@mocsharp mocsharp force-pushed the vchang/102-update-docs-hl7 branch from 8ef0938 to 15b97fb Compare August 15, 2022 18:35
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/102-update-docs-hl7 branch from 3d9269e to 68b0693 Compare August 15, 2022 19:05
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 3851d32 into develop Aug 15, 2022
@mocsharp mocsharp deleted the vchang/102-update-docs-hl7 branch August 15, 2022 22:24
@mocsharp mocsharp modified the milestones: 0.3.0, 0.2.0 Aug 16, 2022
mocsharp added a commit that referenced this pull request Aug 19, 2022
* gh-102 HL7 docs
* Update docfx.json to support net6.0 properly 
* Build solution before buildign docs
* Use windows to build docs
* Updat4e NuGetDefense to continue on error
* Allow retries for HL7 test feature

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HL7v2 MLLP Server

3 participants