Skip to content

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 9, 2022

Description

Expose ConnectionErrorHandler event delegate for IMessageBrokerSubscriberService users to handle connection issues.
The users would need to call Subscribe or SubscribeAsync in order to attach their callback to the new connection model.

For RabbitMQ, the RabbitMQMessageSubscriberService recreates a new channel on model shutdown. If connection cannot be established, it will retry forever (every second) until it's able to reconnect.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Nov 9, 2022
@mocsharp mocsharp added this to the 0.1.11 milestone Nov 9, 2022
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #104 (cc13a7d) into develop (7efbebf) will increase coverage by 3.60206%.
The diff coverage is 48.38710%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #104         +/-   ##
===================================================
+ Coverage   78.65854%   82.26060%   +3.60205%     
===================================================
  Files             42          42                 
  Lines           1312        1274         -38     
  Branches          83          81          -2     
===================================================
+ Hits            1032        1048         +16     
+ Misses           254         197         -57     
- Partials          26          29          +3     
Flag Coverage Δ
unittests 82.26060% <48.38710%> (+3.60205%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Messaging/API/ConnectionErrorArgs.cs 0.00000% <0.00000%> (ø)
...ssaging/Tests/IServiceCollectionExtensionsTests.cs 86.86869% <ø> (ø)
...gins/RabbitMQ/Factory/RabbitMqConnectionFactory.cs 0.00000% <0.00000%> (ø)
src/Plugins/RabbitMQ/Logger.cs 0.00000% <ø> (ø)
...tMQ/Subscriber/RabbitMqMessageSubscriberService.cs 79.68127% <66.66667%> (-4.33700%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efbebf...cc13a7d. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp merged commit 7f99143 into develop Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

🎉 This issue has been resolved in version 0.1.11 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

2 participants