Skip to content

Conversation

neildsouth
Copy link
Member

Description

Fixes # .

Improving logging scope so adds json to message instead of just text

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

mocsharp and others added 7 commits September 20, 2022 09:21
Merge relese/0.1.6 into main.
+semver: patch
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth changed the base branch from develop to release/0.1.7 October 11, 2022 10:20
@neildsouth neildsouth requested a review from mocsharp October 11, 2022 10:20
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #85 (8c7b52b) into release/0.1.7 (3783c3d) will increase coverage by 0.13056%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/0.1.7         #85         +/-   ##
=======================================================
+ Coverage       83.89262%   84.02318%   +0.13056%     
=======================================================
  Files                 41          41                 
  Lines               1192        1208         +16     
  Branches              68          68                 
=======================================================
+ Hits                1000        1015         +15     
- Misses               168         169          +1     
  Partials              24          24                 
Flag Coverage Δ
unittests 84.02318% <100.00000%> (+0.13056%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugins/RabbitMQ/RabbitMqMessagePublisherService.cs 75.00000% <100.00000%> (+2.45098%) ⬆️
...ugins/RabbitMQ/RabbitMqMessageSubscriberService.cs 84.34343% <100.00000%> (+0.92096%) ⬆️
src/Plugins/RabbitMQ/Logger.cs 0.00000% <0.00000%> (-100.00000%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3783c3d...8c7b52b. Read the comment docs.

@mocsharp mocsharp changed the base branch from release/0.1.7 to develop October 11, 2022 15:57
@mocsharp mocsharp merged commit 2b035ac into develop Oct 11, 2022
@mocsharp mocsharp deleted the nds-tweek-logging-scope branch October 11, 2022 15:58
@mocsharp mocsharp added this to the 0.1.8 milestone Oct 11, 2022
@mocsharp mocsharp added the enhancement New feature or request label Oct 11, 2022
@mocsharp mocsharp changed the title Nds tweek logging scope Use structured loggin scope Oct 11, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.8 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants