Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Messaging/Events/ExportCompleteEvent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,27 @@ public class ExportCompleteEvent : EventBase
/// <summary>
/// Gets or sets files exported with its status
/// </summary>
[JsonProperty(PropertyName = "files")]
public Dictionary<string, FileExportStatus> FileStatus { get; set; }
[JsonProperty(PropertyName = "file_statuses")]
public Dictionary<string, FileExportStatus> FileStatuses { get; set; }

[JsonConstructor]
public ExportCompleteEvent()
{
Status = ExportStatus.Unknown;
FileStatus = new Dictionary<string, FileExportStatus>();
FileStatuses = new Dictionary<string, FileExportStatus>();
}

public ExportCompleteEvent(ExportRequestEvent exportRequest, ExportStatus exportStatus)
public ExportCompleteEvent(ExportRequestEvent exportRequest, ExportStatus exportStatus, Dictionary<string, FileExportStatus> fileStatuses)
{
Guard.Against.Null(exportRequest, nameof(exportRequest));
Guard.Against.Null(exportStatus, nameof(exportStatus));
Guard.Against.Null(fileStatuses, nameof(fileStatuses));

WorkflowInstanceId = exportRequest.WorkflowInstanceId;
ExportTaskId = exportRequest.ExportTaskId;
Message = string.Join(System.Environment.NewLine, exportRequest.ErrorMessages);
Status = exportStatus;
FileStatuses = fileStatuses;
}
}
}
10 changes: 10 additions & 0 deletions src/Messaging/Events/ExportStatus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ public enum FileExportStatus
/// </summary>
Success,

/// <summary>
/// Export failed due to configuration error
/// </summary>
ConfigurationError,

/// <summary>
/// File is unsupported
/// </summary>
Expand All @@ -41,6 +46,11 @@ public enum FileExportStatus
/// </summary>
ServiceError,

/// <summary>
/// Error downloading file from storage service
/// </summary>
DownloadError,

/// <summary>
/// Unknown error
/// </summary>
Expand Down
10 changes: 9 additions & 1 deletion src/Messaging/Tests/ExportCompleteEventTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,22 @@ public void ShallGenerateExportCompleteMessageTestFromExportRequestMessage()
Guid.NewGuid().ToString(),
};

var fileStatus = new Dictionary<string, FileExportStatus>()
{
{Guid.NewGuid().ToString(), FileExportStatus.Success},
{Guid.NewGuid().ToString(), FileExportStatus.DownloadError},
{Guid.NewGuid().ToString(), FileExportStatus.ConfigurationError},
};

exportRequestMessage.AddErrorMessages(errors);

var exportCompleteMessage = new ExportCompleteEvent(exportRequestMessage, ExportStatus.Success);
var exportCompleteMessage = new ExportCompleteEvent(exportRequestMessage, ExportStatus.Success, fileStatus);

Assert.Equal(exportRequestMessage.WorkflowInstanceId, exportCompleteMessage.WorkflowInstanceId);
Assert.Equal(exportRequestMessage.ExportTaskId, exportCompleteMessage.ExportTaskId);
Assert.Equal(string.Join(Environment.NewLine, errors), exportCompleteMessage.Message);
Assert.Equal(ExportStatus.Success, exportCompleteMessage.Status);
Assert.Equal(fileStatus, exportCompleteMessage.FileStatuses);
}

[Fact(DisplayName = "Validation shall throw on error")]
Expand Down
8 changes: 7 additions & 1 deletion src/Plugins/RabbitMQ/RabbitMqMessagePublisherService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Globalization;
using System.Threading.Tasks;
using Ardalis.GuardClauses;
Expand Down Expand Up @@ -99,7 +100,12 @@ public Task Publish(string topic, Message message)
Guard.Against.NullOrWhiteSpace(topic, nameof(topic));
Guard.Against.Null(message, nameof(message));

using var loggerScope = _logger.BeginScope(string.Format(CultureInfo.InvariantCulture, Logger.LoggingScopeMessageApplication, message.MessageId, message.ApplicationId));
using var loggingScope = _logger.BeginScope(new Dictionary<string, object>
{
["MessageId"] = message.MessageId,
["ApplicationId"] = message.ApplicationId,
["CorrelationId"] = message.CorrelationId
});

_logger.PublshingRabbitMQ(_endpoint, _virtualHost, _exchange, topic);

Expand Down
15 changes: 13 additions & 2 deletions src/Plugins/RabbitMQ/RabbitMqMessageSubscriberService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ public void Subscribe(string[] topics, string queue, Action<MessageReceivedEvent
var consumer = new EventingBasicConsumer(_channel);
consumer.Received += (model, eventArgs) =>
{
using var loggerScope = _logger.BeginScope(string.Format(CultureInfo.InvariantCulture, Logger.LoggingScopeMessageApplication, eventArgs.BasicProperties.MessageId, eventArgs.BasicProperties.AppId));
using var loggingScope = _logger.BeginScope(new Dictionary<string, object>
{
["MessageId"] = eventArgs.BasicProperties.MessageId,
["ApplicationId"] = eventArgs.BasicProperties.AppId,
["CorrelationId"] = eventArgs.BasicProperties.CorrelationId
});

_logger.MessageReceivedFromQueue(queueDeclareResult.QueueName, eventArgs.RoutingKey);

Expand Down Expand Up @@ -200,7 +205,13 @@ public void SubscribeAsync(string[] topics, string queue, Func<MessageReceivedEv
var consumer = new EventingBasicConsumer(_channel);
consumer.Received += async (model, eventArgs) =>
{
using var loggerScope = _logger.BeginScope(string.Format(CultureInfo.InvariantCulture, Logger.LoggingScopeMessageApplication, eventArgs.BasicProperties.MessageId, eventArgs.BasicProperties.AppId));
using var loggingScope = _logger.BeginScope(new Dictionary<string, object>
{
["MessageId"] = eventArgs.BasicProperties.MessageId,
["ApplicationId"] = eventArgs.BasicProperties.AppId,
["CorrelationId"] = eventArgs.BasicProperties.CorrelationId

});

_logger.MessageReceivedFromQueue(queueDeclareResult.QueueName, eventArgs.RoutingKey);

Expand Down