Skip to content

Update key for WorkflowTemplateName and Storage lib to 0.2.1 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2022
Merged

Update key for WorkflowTemplateName and Storage lib to 0.2.1 #367

merged 3 commits into from
Aug 24, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Aug 23, 2022 •
edited
Loading

Description

  • The name of the key used for storing the Argo template was changed to workflow_id. Changing it to workflow_template_name to avoid confusion.
  • Update storage lib to 0.2.1

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp force-pushed the vchang/workflow-template-name branch 2 times, most recently from ee23b97 to 5d32154 Compare August 23, 2022 21:35
@mocsharp
Update key for WorkflowTemplateName and Storage lib to 0.2.1
848662d 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Remove & kestral & port from TaskManager
a445523 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/workflow-template-name branch from 1098524 to a445523 Compare August 24, 2022 16:34
@mocsharp
Update docs to use workflow_template_name
bba091a 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@mocsharp mocsharp merged commit 200aec2 into develop Aug 24, 2022
@mocsharp mocsharp deleted the vchang/workflow-template-name branch August 24, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackschofield23 jackschofield23 jackschofield23 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mocsharp @jackschofield23