Skip to content

Update key for WorkflowTemplateName and Storage lib to 0.2.1 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Update key for WorkflowTemplateName and Storage lib to 0.2.1 #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
848662d
Update key for WorkflowTemplateName and Storage lib to 0.2.1
mocsharp Aug 23, 2022
a445523
Remove & kestral & port from TaskManager
mocsharp Aug 23, 2022
bba091a
Update docs to use workflow_template_name
mocsharp Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
.docs/
.demos/
.run/

nuget.config

### Csharp ###
## Ignore Visual Studio temporary files, build results, and
Expand Down
13 changes: 4 additions & 9 deletions TaskManager.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021 MONAI Consortium
# Copyright 2021-2022 MONAI Consortium
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Expand Down Expand Up @@ -43,18 +43,13 @@ RUN apt-get clean \
&& rm -rf /var/lib/apt/lists

WORKDIR /opt/monai/wm
COPY --from=build /app/out .
#COPY docs/compliance/open-source-licenses.md .

COPY --from=build /app/out .
COPY LICENSE ./
COPY --from=build /tools /opt/dotnetcore-tools

COPY --from=build /app/mc /usr/local/bin/mc
# RUN mv mc /usr/local/bin/mc

EXPOSE 104
EXPOSE 5000

RUN ls -lR /opt/monai/wm
ENV PATH="/opt/dotnetcore-tools:${PATH}"

ENTRYPOINT ["/opt/monai/wm/Monai.Deploy.WorkflowManager"]
ENTRYPOINT ["/opt/monai/wm/Monai.Deploy.WorkflowManager.TaskManager"]
1 change: 0 additions & 1 deletion WorkflowManager.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ COPY --from=build /tools /opt/dotnetcore-tools
COPY --from=build /app/mc /usr/local/bin/mc
# RUN mv mc /usr/local/bin/mc

EXPOSE 104
EXPOSE 5000

RUN ls -lR /opt/monai/wm
Expand Down
2 changes: 1 addition & 1 deletion guidelines/mwm-developer-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Open the post/workflows tab and click `try it out`, paste in the following to th
"type": "argo",
"args": {
"namespace":"argo",
"workflow_id": "simple-workflow",
"workflow_template_name": "simple-workflow",
"server_url": "https://localhost:2746",
"allow_insecure": true,
"messaging_endpoint": "rabbit-monai",
Expand Down
2 changes: 1 addition & 1 deletion guidelines/static/workflow_examples/scenario1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"description": "Run Image Type Detector",
"ref": "argo",
"args": {
"workflow_id": "image_type_detector"
"workflow_template_name": "image_type_detector"
},
"output": [
{
Expand Down
2 changes: 1 addition & 1 deletion src/Shared/Configuration/Monai.Deploy.WorkflowManager.Configuration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
<PackageReference Include="Karambolo.Extensions.Logging.File" Version="3.3.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="Monai.Deploy.Storage" Version="0.2.0-rc0014" />
<PackageReference Include="Monai.Deploy.Storage" Version="0.2.1" />
<PackageReference Include="System.IO.Abstractions" Version="17.1.1" />
</ItemGroup>

Expand Down
Loading