server-api: Initial MONAID Server API#21
Merged
GreySeaWolf merged 6 commits intomainfrom Sep 29, 2021
Merged
Conversation
This commit adds the initial version of the MONAID Server API (GRPC based). Some elements of the API are marked as "Feature Not Available in Current Version". These items are planned for future versions of the Server.
This change adds ERROR_JOB_UNSCHEDULABLE to the error_code enumeration in the Server API as requested by @pritishnahar95.
This change fixes the comments issue found by @pritishnarah95, which indicate that payload cloning is not available in the initial release, to include all parts of payload cloning.
This change correct an error in the job service status rpc defintion caught by @pritishnahar95. The status rpc incorrectly accepted `JobDetailRequest` and returned `JobDetailResponse` which it should have accepted `JobStatusRequest` and `JobStatusResponse`.
mocsharp
reviewed
Jul 29, 2021
This change fixes a number of issues with the original Server GRPC API proposal which were discovered during first attempted generation. These issues and changes are all syntax corrections, or naming corrections to ensure the GRPC .proto files could be used for code generation.
whoisj
force-pushed
the
whoisj/server-api
branch
from
b210826 to
0f34f53
Compare
This change updates the proposed MONAID Server GRPC API based on feedback from actual development of the v0 Server implementation.
hshuaib90
reviewed
Sep 18, 2021
Collaborator
hshuaib90
left a comment
hshuaib90
left a comment
There was a problem hiding this comment.
Interesting reading. Would be interested in hearing about why GPRC and other design decisions at one of the Thursday meetings, if possible.
GreySeaWolf
approved these changes
Sep 29, 2021
GreySeaWolf
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the initial version of the MONAID Server API (GRPC based).
Some elements of the API are marked as "Feature Not Available in Current Version". These items are planned for future versions of the Server.
The goal of this pull-request is to spark discussion about the features provided by MONAI Deploy Application Server.
I recommend starting with
map.protofile.