Skip to content

Conversation

@tangy5
Copy link
Contributor

@tangy5 tangy5 commented Dec 8, 2022

Hi MONAI Label team @SachidanandAlle @diazandr3s @finalelement @Nic-Ma:

Let's start our MONAILabel tutorial series.

I've made several E2E tutorials for all sample apps with some end tasks.

We will put all MONAI Label related tutorials in this repo.

Some thoughts from my side:

  • In the future, there will be more E2E tutorials for end-users or developers. E.g., OHIF, Orthanc, DSA, Interactive labeling (DeepEdit), Detection...etc....Whenever there is a new viewer/plugin/datastore/task/special feature, we can make a tutorial.
  • The purpose for these tutorials is to provide e2e experience for new users or developers.
  • I will create a doc page in the MONAILabel repo to link these tutorials.
  • If any customer/users/collaborators asks question on viewer/plugin/server installation, setup question, we can help them and refer materials here.

Let me know if you have any thoughts or suggestions for these tutorials.

Cheers.

tangy5 added 3 commits December 7, 2022 21:51
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
@mingxin-zheng
Copy link
Contributor

Hi @tangy5
If 3D Slicer doesn't work in Mac, could you add a note in the notebooks? Thanks!

@mingxin-zheng
Copy link
Contributor

Also I noticed most other notebooks do not use the index (such as 1.1 and 1.1.1) in the titles. I would propose that we can unify so that one day if we need to replace/remove something in all notebooks, it can be easily done in a text editor.

@Nic-Ma Nic-Ma requested a review from wyli December 8, 2022 11:47
@tangy5 tangy5 requested a review from diazandr3s December 8, 2022 15:49
@tangy5
Copy link
Contributor Author

tangy5 commented Dec 8, 2022

Hi @tangy5 If 3D Slicer doesn't work in Mac, could you add a note in the notebooks? Thanks!

Users can use 3D Slicer on Mac, but MONAI Label can't, users can setup MONAI Label server with Linux then use 3D Slicer for annotation on Mac. Just with a host/port pass. That's OK.

Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
@tangy5 tangy5 force-pushed the monailabel_tutorial_series branch from 579793f to de720df Compare December 8, 2022 16:49
@tangy5
Copy link
Contributor Author

tangy5 commented Dec 8, 2022

Also I noticed most other notebooks do not use the index (such as 1.1 and 1.1.1) in the titles. I would propose that we can unify so that one day if we need to replace/remove something in all notebooks, it can be easily done in a text editor.

Emm, let's think about this, MONAI Label tutorials are not fully notebook executable experience, most parts are markdown where users want to read. Like a book chapter. Maybe index is better for these markdown texts.

Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
@tangy5 tangy5 force-pushed the monailabel_tutorial_series branch from a56ec68 to 62054c0 Compare December 8, 2022 17:21
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
@tangy5 tangy5 force-pushed the monailabel_tutorial_series branch from b4629f4 to 2dd1c9a Compare December 9, 2022 02:34
@tangy5
Copy link
Contributor Author

tangy5 commented Dec 9, 2022

Hi @wyli , I guess some checks are canceled due to some configs of notebooks, these MONAI Label tutorials only has bash command, no training/inference executable python codes. Do you have some hints how to pass the premerge-notebooks check?
Thank you so much!

@tangy5 tangy5 marked this pull request as draft December 12, 2022 20:17
@tangy5
Copy link
Contributor Author

tangy5 commented Dec 12, 2022

Convert to Draft for now.
Waiting for decisions on how to handle consistency between Toolkit verison and Github version.

tangy5 and others added 2 commits January 3, 2023 12:30
tangy5 and others added 2 commits January 4, 2023 07:48
@tangy5 tangy5 marked this pull request as ready for review January 4, 2023 17:07
@wyli wyli requested a review from mingxin-zheng January 4, 2023 17:36
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me. for the readme file, perhaps we can include more info about

  • minimal hardware requirements, operating system?
  • where to ask monailabel questions/create bug reports?
  • references of monailabel paper?
  • the URLs for the 3rd party software?

tangy5 and others added 6 commits January 4, 2023 15:11
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
@tangy5 tangy5 merged commit 5883235 into Project-MONAI:main Jan 5, 2023
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Hi MONAI Label team @SachidanandAlle @diazandr3s @finalelement @Nic-Ma:

Let's start our MONAILabel tutorial series. 

I've made several E2E tutorials for all sample apps with some end tasks.

We will put all MONAI Label related tutorials in this repo. 

Some thoughts from my side:

- In the future, there will be more E2E tutorials for end-users or
developers. E.g., OHIF, Orthanc, DSA, Interactive labeling (DeepEdit),
Detection...etc....Whenever there is a new
viewer/plugin/datastore/task/special feature, we can make a tutorial.
- The purpose for these tutorials is to provide e2e experience for new
users or developers.
- I will create a doc page in the MONAILabel repo to link these
tutorials.
- If any customer/users/collaborators asks question on
viewer/plugin/server installation, setup question, we can help them and
refer materials here.

Let me know if you have any thoughts or suggestions for these tutorials.

Cheers.

Signed-off-by: tangy5 <yucheng.tang@vanderbilt.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants