Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jan 6, 2023

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #1143

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • Remove private info such as user name and private key from the notebook and script files.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review January 6, 2023 12:11
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jan 6, 2023

I've enabled the DCO config in this PR @mingxin-zheng

@wyli wyli requested a review from mingxin-zheng January 6, 2023 12:14
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@mingxin-zheng
Copy link
Contributor

Looks good and thanks!

@wyli wyli merged commit b8ed687 into Project-MONAI:main Jan 6, 2023
@wyli wyli deleted the dco-test branch January 6, 2023 12:30
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

part of Project-MONAI#1143

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] Remove private info such as user name and private key from the
notebook and script files.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants