Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jan 11, 2023

Fixes #1153.

Description

  • Fix the typo in ScaleIntensityRanged

ScaleIntensityRanged(keys=["image"], a_min=np.float32(255), a_max=np.float32(0)),

  • update performance figures with correct normalization

Checks

  • Avoid including large-size files in the PR.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

KumoLiu and others added 30 commits July 21, 2022 10:22
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from Nic-Ma, bhashemian and wyli January 11, 2023 14:01
Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli wyli merged commit 1cee348 into Project-MONAI:main Jan 11, 2023
@KumoLiu KumoLiu deleted the fix-typo branch January 12, 2023 02:00
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes Project-MONAI#1153.

### Description

- Fix the typo in `ScaleIntensityRanged`


https://github.com/Project-MONAI/tutorials/blob/e5a1876ec41be44ac7185b07768177110c316f52/pathology/multiple_instance_learning/panda_mil_train_evaluate_pytorch_gpu.py#L296

- update performance figures with correct normalization

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: KumoLiu <yunl@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Instance Learning: SplitDimd TypeError: __init__() got an unexpected keyword argument 'list_output'

2 participants