Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jan 17, 2024

Fixes #1617

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KumoLiu KumoLiu marked this pull request as ready for review January 17, 2024 06:04
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested review from Nic-Ma and ericspod January 17, 2024 06:36
@ericspod
Copy link
Member

Hi @KumoLiu I see a few formatting issues that are unrelated to the fix but are important to undo. I see a number of other changes in the JSON for these notebooks, I don't know if it's an issue or not however. Looks good otherwise, thanks.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 18, 2024

Hi @KumoLiu I see a few formatting issues that are unrelated to the fix but are important to undo. I see a number of other changes in the JSON for these notebooks, I don't know if it's an issue or not however. Looks good otherwise, thanks.

Hi @ericspod, yes. they are changed by the autofix, I will revert them today. Thanks.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod
Copy link
Member

I might have flagged issues again before you had a chance to get them, ignore later comments if so!

…hub.com>

I, YunLiu <55491388+KumoLiu@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 3ec08dd

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested a review from ericspod January 18, 2024 16:21
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@KumoLiu KumoLiu enabled auto-merge (squash) January 19, 2024 02:34
@KumoLiu KumoLiu merged commit fde5497 into Project-MONAI:main Jan 19, 2024
@KumoLiu KumoLiu deleted the flake8 branch January 19, 2024 02:34
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes Project-MONAI#1617


### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

B038 errors after flake8-bugbear upgrade

2 participants