Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 24, 2024

Fixes #1843

Description

A few sentences describing the changes proposed in this pull request.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested review from Nic-Ma and ericspod September 25, 2024 05:53
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 25, 2024

Hi @finalelement, could you please help review this update in the active learning tutorials? Thanks.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod ericspod merged commit 00484e0 into Project-MONAI:main Sep 25, 2024
@ericspod
Copy link
Member

Whoops, might have merged too eagerly. @finalelement if you had any further comments we can integrate them into a subsequent PR, thanks.

@finalelement
Copy link
Contributor

@ericspod I think you made a good call, @KumoLiu the changes look benign and do not seem that would cause any harm. Thank you for updating the tutorial.

@KumoLiu KumoLiu deleted the fix-active-learning branch September 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected keyword argument 'dimensions' in liver_tumor_al/results_uncertainty_analysis.ipynb

3 participants