Skip to content

update monai nvflare example links#2062

Merged
holgerroth merged 1 commit intoProject-MONAI:mainfrom
holgerroth:update-monai-nvflare-link
Apr 14, 2026
Merged

update monai nvflare example links#2062
holgerroth merged 1 commit intoProject-MONAI:mainfrom
holgerroth:update-monai-nvflare-link

Conversation

@holgerroth
Copy link
Copy Markdown
Contributor

@holgerroth holgerroth commented Apr 14, 2026

Fixes # .

Description

Update link for NVFlare based Federated Learning examples to link to the latest version in the NVFlare repo.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Summary by CodeRabbit

  • Documentation
    • Updated documentation references for NVFlare MONAI FL integration examples to point to the latest stable version.

Signed-off-by: Holger Roth <hroth@nvidia.com>
@holgerroth holgerroth requested review from Nic-Ma and garciadias April 14, 2026 19:41
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

Walkthrough

Updated a documentation reference link in the NVFlare README from the dev branch to the main branch, reflecting a change in the canonical documentation location. No functional changes.

Changes

Cohort / File(s) Summary
Documentation Link Update
federated_learning/nvflare/README.md
Updated MONAI FL integration examples link from dev branch to main branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰✨ A link once pointed down dev's way,
Now main branch shows the light of day,
With just one hop through branches fair,
The docs now shine without a care! 📚

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main change: updating links to NVFlare MONAI federated learning examples to point to the main branch instead of dev.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description is mostly complete with a clear description of changes and a properly filled checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@federated_learning/nvflare/README.md`:
- Line 4: Replace the generic link text "here" in the README's link line with a
descriptive label to satisfy markdownlint MD059; change the anchor to something
like "NVFlare MONAI integration examples" so the line reads: "Please visit
NVFlare MONAI integration examples" with the same URL, ensuring the visible link
text is descriptive and accessible.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ec357606-30e1-46b3-89bf-8103074d1e8f

📥 Commits

Reviewing files that changed from the base of the PR and between 60cf9ac and a2a0e74.

📒 Files selected for processing (1)
  • federated_learning/nvflare/README.md

@holgerroth holgerroth enabled auto-merge (squash) April 14, 2026 19:46
Copy link
Copy Markdown
Contributor

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Approved.

@holgerroth holgerroth merged commit 5c908aa into Project-MONAI:main Apr 14, 2026
7 checks passed
@holgerroth holgerroth deleted the update-monai-nvflare-link branch April 14, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants