Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jul 5, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Description

update to use metatensor

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli changed the title update load image demo update tutorials/modules for metatensor Jul 11, 2022
@wyli wyli force-pushed the update-modules branch from 193c33a to f623512 Compare July 11, 2022 12:23
@wyli wyli marked this pull request as ready for review July 11, 2022 13:45
@wyli wyli marked this pull request as draft July 12, 2022 08:01
wyli added 13 commits July 12, 2022 15:34
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the update-modules branch from 869ebb4 to 822b719 Compare July 12, 2022 19:42
wyli added 4 commits July 12, 2022 16:15
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review July 12, 2022 20:59
@wyli
Copy link
Contributor Author

wyli commented Jul 12, 2022

Hi @Nic-Ma @yiheng-wang-nv, I've reviewed all notebooks in modules/ (except dynunet_pipeline and bundle). please help review these changes.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
Looks good to me, put some question inline.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) July 13, 2022 06:43
@wyli wyli merged commit 740ebbb into Project-MONAI:main Jul 13, 2022
@wyli wyli deleted the update-modules branch July 14, 2022 20:18
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* update load image demo

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update 2d_slices_from_3d_training.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* image_dataset.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes fasttraining

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tta

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* nifti read

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tta

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typos

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes interpretability/cats_and_dogs.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes pep8

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* pep8

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update 2d_slices_from_3d_sampling.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* modules/resample_benchmark.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* modules/benchmark_global_mutual_information.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update modules/nifti_read_example.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* modules/integrate_3rd_party_transforms.ipynb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes pep8

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants