59 fix params dict serializing and deserializing#60
Merged
lfse-slafleur merged 6 commits intomainfrom Jul 25, 2024
Merged
Conversation
lfse-slafleur
commented
Jul 24, 2024
| elif isinstance(value, timedelta): | ||
| elif type(value) is timedelta: | ||
| normalized_dict[key] = value.total_seconds() | ||
| elif type(value) is int: |
Member
Author
There was a problem hiding this comment.
It turns out that isinstance(True, int) == True. As in bool values in Python are also integers. Never knew this xD
cwang39403
reviewed
Jul 24, 2024
cwang39403
reviewed
Jul 24, 2024
cwang39403
reviewed
Jul 24, 2024
MarkTNO
approved these changes
Jul 25, 2024
cwang39403
approved these changes
Jul 25, 2024
lfse-slafleur
deleted the
59-fix-params-dict-serializing-and-deserializing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.