76: Add job reference and use it to determine output_esdl name.#77
Merged
lfse-slafleur merged 5 commits intomainfrom Oct 15, 2024
Merged
76: Add job reference and use it to determine output_esdl name.#77lfse-slafleur merged 5 commits intomainfrom
lfse-slafleur merged 5 commits intomainfrom
Conversation
MarkTNO
approved these changes
Oct 11, 2024
| elif job_reference == "": | ||
| output_energy_system.name = f"{input_energy_system.name}" | ||
| else: | ||
| output_energy_system.name = f"{input_energy_system.name}_{job_reference}" |
Contributor
There was a problem hiding this comment.
should we replace invalid xml characters with _ for example?
Member
Author
There was a problem hiding this comment.
Good catch! Checked what happened when I inserted reserved characters in the job reference. Pyesdl already takes care of the necessary escaping:
<esdl:EnergySystem xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:esdl="http://www.tno.nl/esdl" id="c53b2878-6f0e-49fb-b9a1-9aeb8b808117" description="" name="Untitled EnergySystem with return network_example_sdk_client.simulator %>>&#(@#)(@#$<>)(ASd<<<>>>>>" version="1" esdlVersion="v2207">| once the result is received and handled without exceptions through | ||
| `callback_on_finished`. | ||
| :param job_reference: An optional reference to the submitted job which is used in the | ||
| name of the output ESDL as well as in internal logging of OMOTES. |
Contributor
There was a problem hiding this comment.
Very nice to have it in the internal logging as well. This is to be implemented?
Member
Author
There was a problem hiding this comment.
Yes! Originally meant for a more bare implementation to check if the implementation fits everyone. Logging introduced here: e670131
…d in JobSubmission.
MarkTNO
approved these changes
Oct 15, 2024
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.