Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates OSRM’s “Get in Touch” section to reflect current community contact channels and updates the corresponding social icon sprite.
Changes:
- Replaces the IRC link with a Discord invite link.
- Replaces the Twitter link with a Mastodon profile link.
- Updates the third social icon in
social_icons.svgto match the new social link.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
index.html |
Updates the displayed social/contact links in the “Get in Touch” section. |
images/social_icons.svg |
Replaces the third icon glyph in the social icons sprite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
66
to
70
| <div class='col2 hide-mobile '> | ||
| <div class='social-icons social3-icon'></div> | ||
| </div> | ||
| <div class='col9 margin1'><a href='https://twitter.com/ProjectOSRM'>Twitter</a></div> | ||
| <div class='col9 margin1'><a href='https://en.osm.town/@osrm'>Mastodon</a></div> | ||
| </div> |
There was a problem hiding this comment.
There appears to be an extra closing in this social link row. After the col9 link div closes, another is emitted, which makes the DOM nesting invalid and can break layout. Remove the stray closing tag or adjust the nesting so the row has balanced open/close tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.