Fix spectro data from file split#346
Merged
Gautzilla merged 3 commits intoProject-OSmOSE:mainfrom Mar 11, 2026
Merged
Conversation
Collaborator
ElodieENSTA
approved these changes
Mar 11, 2026
Member
ElodieENSTA
left a comment
ElodieENSTA
left a comment
There was a problem hiding this comment.
The split method now works when no AudioData exists! 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐳 Sup?
There was a (well, actually two) bug with splitting a
SpectroDatathat was parsed from files : it tried to split its linkedAudioData, which didn't exist.Now, splitting a
SpectroDatathat has associated files works in the same way as theBaseDatasays: throughSpectroData._make_split_data(), which was originally left abstract.It highlighted another bug in the
SpectroFile.read()method, where a bin was included if it included either the begin or end timestamp: bins were duplicated during the split data concatenation.Everything should work fine now!