Skip to content

feat(settings): support avatar upload and robust avatar deletion#38

Merged
ZhangHanDong merged 1 commit intoProject-Robius-China:mainfrom
tyreseluo:feat/settings-avatar-upload-delete
Apr 2, 2026
Merged

feat(settings): support avatar upload and robust avatar deletion#38
ZhangHanDong merged 1 commit intoProject-Robius-China:mainfrom
tyreseluo:feat/settings-avatar-upload-delete

Conversation

@tyreseluo
Copy link
Copy Markdown

Summary

  • Add avatar upload support in Account Settings on desktop platforms.
  • Introduce MatrixRequest::UploadAvatar flow to upload selected PNG/JPEG files.
  • Add compatibility fallback for avatar deletion when homeserver returns M_UNRECOGNIZED on delete-avatar endpoint.
  • Show clear "not yet supported" notifications for avatar upload/delete on non-desktop platforms.

Changes

  • Update settings UI logic to:
  • Open a file picker for avatar upload on desktop.
  • Trigger upload spinner/action state while upload is in progress.
  • Show platform-specific warning on mobile for avatar actions.
  • Update sliding sync worker to:
  • Handle UploadAvatar by reading local file, validating PNG/JPEG, and calling account avatar upload.
  • Retry avatar deletion via fallback request when standard deletion path fails with M_UNRECOGNIZED.
  • Add required dependencies:
  • mime for content type handling.
  • rfd (desktop-only target dependency) for file picker support.

Validation

  • cargo check passes.
  • Manual behavior covered:
  • Avatar can be uploaded from settings on desktop.
  • Avatar deletion gracefully handles servers that reject the newer deletion endpoint.
  • Mobile avatar actions show explicit not-supported notifications.

- add desktop avatar file picker upload flow in account settings\n- add MatrixRequest::UploadAvatar worker path with PNG/JPEG validation\n- add fallback delete-avatar request for homeservers returning M_UNRECOGNIZED\n- show not-supported notices for avatar actions on mobile platforms
@tyreseluo tyreseluo self-assigned this Apr 1, 2026
@ZhangHanDong ZhangHanDong merged commit d9b022c into Project-Robius-China:main Apr 2, 2026
@tyreseluo tyreseluo deleted the feat/settings-avatar-upload-delete branch April 2, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants