Add JONSWAP spectrum + random seed#47
Merged
dav-og merged 2 commits intoProject-SEA-Stack:mainfrom Nov 23, 2023
Merged
Conversation
dav-og
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the JONSWAP spectrum, and is calculated in the code by first getting the spectral densities from the Pierson-Moskowitz spectrum and then scaling it with the peak enhancement factor factor. By default, the peak enhancement factor is 1.0, which keeps the spectrum equivalent to Pierson-Moskowitz (as used in tests).
The random seed was also exposed in the IrregularWaveParams struct so it can be set by the user.