Refactor Chrono linkage and improve build, data, and test infrastructure#79
Merged
Refactor Chrono linkage and improve build, data, and test infrastructure#79
Conversation
Replaced duplicate find_package(Chrono ...) calls and remove ${CHRONO_TARGETS}
…d target current HDF5 package versions
… during CMake configuration
- rename test source file names to follow the pattern test_***.cpp - rename Python scripts for regression testing to match the corresponding test names - relocate test executables to the project binary directory
…emos and regression tests
- Move CMake configuration in its own directory - Simplify access to necessary Chrono data (for Irrlicht visualization)
- prefer using Chrono data subdirectory from under the HydroChrono data directory. - fall back on the data directory of the Chrono installation used during HydroChrono configuration.
to run tests from build directory: > ctest -C Release -L regression
- Fix CPack packaging to include HDF5 and Irrlicht DLLs - Fix data directory install path (trailing slash issue) - Include test input data (YAML, H5, geometry) in package - Set HYDROCHRONO_DATA_DIR in RUN-TESTS.ps1 for portable execution - Remove deprecated Chrono API calls (GetTypeAsString) in regression tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates HydroChrono’s integration with Project Chrono and cleans up several parts of the build and data infrastructure. The main goal is to lay the groundwork for future Chrono::FSI integration while also making builds more reliable and tests/demos easier to run across platforms.
Highlights
Summary
Follow-up
DLL inclusion in the CPack package currently relies on a filesystem glob. This works but is fragile; we should replace it with explicit target-based dependency collection in a future update.
Acknowledgement
Massive thanks to Radu (@rserban) for doing this work to improve HydroChrono's build/data/visualization infrastructure!