Conversation
Address MSVC warnings (C4005, C4018, C4189, C4267) Changes: - Remove conflicting CHRONO_VERSION macro definition in logging.h; add fallback in logger_backend.cpp to avoid conflict with Chrono's ChVersion.h (C4005) - Use Eigen::Index for Eigen container loops instead of int/size_t (C4018) - Use size_t for STL container loops in demos/tests (C4018) - Add explicit casts for size_t-to-int conversions where APIs require int (C4267) - Remove unused variables: rest_length, col_dof, total_dofs, bodies, dampers, samples, width_array (C4189) - Fix variable shadowing: rename t_tau to t_tau_init in ExcitationConvolution - Mark Irrlicht includes as SYSTEM in CMakeLists.txt to suppress warnings Build tested: Release configuration, all (working) regression tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address MSVC warnings (C4005, C4018, C4189, C4267).
Changes
CHRONO_VERSIONmacro; add fallback inlogger_backend.cppEigen::Indexfor Eigen containers,size_tfor STL containersintrest_length,col_dof,total_dofs,width_array, etc.t_tau→t_tau_initinExcitationConvolutionSYSTEMin CMakeLists.txtTested: Release build, regression tests pass.