fix: ps.createShop for qb#38
Merged
Merged
Conversation
Contributor
Author
|
Hey @xFutte , just tagging you in case this didn’t show up in your notifications. This PR fixes the shops not opening for qb-inv |
Contributor
|
@Mustachedom I believe would be better to tag |
Contributor
|
had this sitting on my local branch fixed thinking i already PRed :kek: my bad, looks good to me @TheMajorMayhem |
Mustachedom
approved these changes
Nov 19, 2025
Contributor
Author
|
@ThatMadCap just a quick follow-up on this PR it’s already approved, so let me know if you need anything else from me before merging, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ps.createShop only sent the name and items to qb-inventory, so the export got a number as shopData and threw the
attempt to index a number value (local 'shopData')error. This PR fixes that.