Handle empty HTTP response in versionCheck#41
Merged
Conversation
Return early in the PerformHttpRequest callback when the response body is nil or not a string to avoid runtime errors when iterating with string.gmatch. Adds a debug log including the error info and prevents further processing of an empty/invalid remote response.
Add robust version parsing and comparison utilities (ps._splitVersion, ps._compareVersions) and refactor ps.versionCheck to validate inputs, fetch and parse remote version tokens (handles "Newest Build:" and semantic version patterns), compare installed vs remote versions, and log appropriate messages. Supports an opts.showChangelog flag to optionally display changelog lines and includes a convenience example call. Improved error handling and clearer debug/warn/info output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return early in the PerformHttpRequest callback when the response body is nil or not a string to avoid runtime errors when iterating with string.gmatch. Adds a debug log including the error info and prevents further processing of an empty/invalid remote response.