Re-enable dropped smarty5 modifier 'range' #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modifier after dropped in smarty5
dontub
approved these changes
Sep 15, 2025
Collaborator
dontub
left a comment
dontub
left a comment
There was a problem hiding this comment.
Apart from the quote issue (see code comment) I'm fine with it.
CRM/Banking/Form/StatementSearch.php
Outdated
|
|
||
| $this->buildSearchElements(); | ||
|
|
||
| CRM_Core_Smarty::singleton()->registerPlugin("modifier", "range", "range"); |
Collaborator
There was a problem hiding this comment.
I think we should use single quotes instead of double quotes, unless there's a reason to use double quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systopia-reference: 29664
The
@rangemodifier was dropped from the default modifiers with smarty5.This PR will add the the modifier again where needed.