Skip to content

fix: updates based on changes in asap_sketchlib's API #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 2 commits into from
Apr 16, 2026
Merged

fix: updates based on changes in asap_sketchlib's API #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ab79c
fix: updates based on changes in asap_sketchlib's API
milindsrivastava1997 Apr 16, 2026
e57d1cf
fix
milindsrivastava1997 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
167 changes: 19 additions & 148 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions asap-common/sketch-core/src/count_min_sketchlib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use asap_sketchlib::{CountMin, RegularPath, SketchInput, Vector2D};
use asap_sketchlib::{CountMin, DataInput, RegularPath, Vector2D};

/// Concrete Count-Min type from asap_sketchlib when sketchlib backend is enabled.
/// Uses f64 counters (Vector2D<f64>) for weighted updates without integer rounding.
Expand Down Expand Up @@ -48,12 +48,12 @@ pub fn sketchlib_cms_update(inner: &mut SketchlibCms, key: &str, value: f64) {
if value <= 0.0 {
return;
}
let input = SketchInput::String(key.to_owned());
let input = DataInput::String(key.to_owned());
inner.insert_many(&input, value);
}

/// Helper to query a sketchlib Count-Min for a key, returning f64.
pub fn sketchlib_cms_query(inner: &SketchlibCms, key: &str) -> f64 {
let input = SketchInput::String(key.to_owned());
let input = DataInput::String(key.to_owned());
inner.estimate(&input)
}
Loading
Loading