Merged
Conversation
zzylol
added a commit
that referenced
this pull request
May 1, 2026
Update PR #307 against the reorganized asap_sketchlib (PR #36) — runtime sketches now live in the existing src/sketches/ layout (single home per sketch concept), not under a separate `asap::` namespace. Path swaps in asap-query-engine (legacy fork; smaller surface than ASAPQuery-backend — no DDSketch / CountSketch / HllSketch accumulators): - asap_sketchlib::asap::count_min::* → ::sketches::countmin::* - asap_sketchlib::asap::kll::* → ::sketches::kll::* - asap_sketchlib::asap::count_min_with_heap::* → ::sketches::cms_heap::* - asap_sketchlib::asap::hydra_kll::* → ::sketches::hydra_kll::* - asap_sketchlib::asap::set_aggregator::* → ::sketches::set_aggregator::* - asap_sketchlib::asap::delta_set_aggregator::* → ::sketches::delta_set_aggregator::* - asap_sketchlib::asap::config::* → ::asap_runtime::* Rename carried through: - HeapItem → CmsHeapItem (avoids common::input::HeapItem collision) main.rs aliases asap_runtime as `config` so existing clap-derive references keep working. Tests: - cargo check -p query_engine_rust → clean - cargo test -p query_engine_rust --lib precompute_operators → 87 passed, 0 failed Depends on ProjectASAP/asap_sketchlib#36 (force-pushed e473ccc). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
May 1, 2026
Update PR #307 against the reorganized asap_sketchlib (PR #36) — runtime sketches now live in the existing src/sketches/ layout (single home per sketch concept), not under a separate `asap::` namespace. Path swaps in asap-query-engine (legacy fork; smaller surface than ASAPQuery-backend — no DDSketch / CountSketch / HllSketch accumulators): - asap_sketchlib::asap::count_min::* → ::sketches::countmin::* - asap_sketchlib::asap::kll::* → ::sketches::kll::* - asap_sketchlib::asap::count_min_with_heap::* → ::sketches::cms_heap::* - asap_sketchlib::asap::hydra_kll::* → ::sketches::hydra_kll::* - asap_sketchlib::asap::set_aggregator::* → ::sketches::set_aggregator::* - asap_sketchlib::asap::delta_set_aggregator::* → ::sketches::delta_set_aggregator::* - asap_sketchlib::asap::config::* → ::asap_runtime::* Rename carried through: - HeapItem → CmsHeapItem (avoids common::input::HeapItem collision) main.rs aliases asap_runtime as `config` so existing clap-derive references keep working. Tests: - cargo check -p query_engine_rust → clean - cargo test -p query_engine_rust --lib precompute_operators → 87 passed, 0 failed Depends on ProjectASAP/asap_sketchlib#36 (force-pushed e473ccc). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
refactor/retire-sketch-core-asap-sketchlib-main
branch
from
d1ed32d to
4af8953
Compare
zzylol
added a commit
that referenced
this pull request
May 1, 2026
Update PR #307 against the reorganized asap_sketchlib (PR #36) — runtime sketches now live in the existing src/sketches/ layout (single home per sketch concept), not under a separate `asap::` namespace. Path swaps in asap-query-engine (legacy fork; smaller surface than ASAPQuery-backend — no DDSketch / CountSketch / HllSketch accumulators): - asap_sketchlib::asap::count_min::* → ::sketches::countmin::* - asap_sketchlib::asap::kll::* → ::sketches::kll::* - asap_sketchlib::asap::count_min_with_heap::* → ::sketches::cms_heap::* - asap_sketchlib::asap::hydra_kll::* → ::sketches::hydra_kll::* - asap_sketchlib::asap::set_aggregator::* → ::sketches::set_aggregator::* - asap_sketchlib::asap::delta_set_aggregator::* → ::sketches::delta_set_aggregator::* - asap_sketchlib::asap::config::* → ::asap_runtime::* Rename carried through: - HeapItem → CmsHeapItem (avoids common::input::HeapItem collision) main.rs aliases asap_runtime as `config` so existing clap-derive references keep working. Tests: - cargo check -p query_engine_rust → clean - cargo test -p query_engine_rust --lib precompute_operators → 87 passed, 0 failed Depends on ProjectASAP/asap_sketchlib#36 (force-pushed e473ccc). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
refactor/retire-sketch-core-asap-sketchlib-main
branch
from
4af8953 to
9c96274
Compare
Update PR #307 against the reorganized asap_sketchlib (PR #36) — runtime sketches now live in the existing src/sketches/ layout (single home per sketch concept), not under a separate `asap::` namespace. Path swaps in asap-query-engine (legacy fork; smaller surface than ASAPQuery-backend — no DDSketch / CountSketch / HllSketch accumulators): - asap_sketchlib::asap::count_min::* → ::sketches::countmin::* - asap_sketchlib::asap::kll::* → ::sketches::kll::* - asap_sketchlib::asap::count_min_with_heap::* → ::sketches::cms_heap::* - asap_sketchlib::asap::hydra_kll::* → ::sketches::hydra_kll::* - asap_sketchlib::asap::set_aggregator::* → ::sketches::set_aggregator::* - asap_sketchlib::asap::delta_set_aggregator::* → ::sketches::delta_set_aggregator::* - asap_sketchlib::asap::config::* → ::asap_runtime::* Rename carried through: - HeapItem → CmsHeapItem (avoids common::input::HeapItem collision) main.rs aliases asap_runtime as `config` so existing clap-derive references keep working. Tests: - cargo check -p query_engine_rust → clean - cargo test -p query_engine_rust --lib precompute_operators → 87 passed, 0 failed Depends on ProjectASAP/asap_sketchlib#36 (force-pushed e473ccc). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
refactor/retire-sketch-core-asap-sketchlib-main
branch
from
9c96274 to
e2e4b67
Compare
This was referenced May 2, 2026
zzylol
added a commit
that referenced
this pull request
May 2, 2026
zzylol
added a commit
that referenced
this pull request
May 2, 2026
zzylol
added a commit
that referenced
this pull request
May 2, 2026
After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
May 2, 2026
After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
milindsrivastava1997
pushed a commit
that referenced
this pull request
May 4, 2026
…est fix (#309) * Revert "Revert "refactor: retire sketch-core mirror (#307)" (#310)" This reverts commit ea723f4. * chore: track asap_sketchlib main + fix elastic DSL quantile assert After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
milindsrivastava1997
deleted the
refactor/retire-sketch-core-asap-sketchlib-main
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retire the vendored
sketch-corecrate. Switch query-engine consumer imports to the reorganizedasap_sketchlib(#36 — runtime sketches now embedded in the existingsrc/sketches/layout, no separateasap::namespace).Mechanical path swaps
sketch-core→ first cut on PR #36)asap_sketchlib::asap::count_min::*asap_sketchlib::sketches::countmin::*asap_sketchlib::asap::kll::*asap_sketchlib::sketches::kll::*asap_sketchlib::asap::count_min_with_heap::*asap_sketchlib::sketches::cms_heap::*asap_sketchlib::asap::hydra_kll::*asap_sketchlib::sketches::hydra_kll::*asap_sketchlib::asap::set_aggregator::*asap_sketchlib::sketches::set_aggregator::*asap_sketchlib::asap::delta_set_aggregator::*asap_sketchlib::sketches::delta_set_aggregator::*asap_sketchlib::asap::config::*asap_sketchlib::asap_runtime::*(This legacy fork doesn't have DDSketch / CountSketch / HllSketch accumulators — those live only in ASAPQuery-backend.)
Renames carried through
HeapItem→CmsHeapItem(avoids collision withcommon::input::HeapItem)main.rsaliasesasap_sketchlib::asap_runtime as configso the existing clap-derive references (config::DEFAULT_CMS_IMPL,config::configure(...)) keep working without touching the rest of the bin.Workspace cleanup
asap-common/sketch-core/deleted.Cargo.toml; query-engineCargo.tomlno longer pullssketch-core.asap-common/sketch-core.Tests
```
CARGO_NET_GIT_FETCH_WITH_CLI=true cargo check -p query_engine_rust → clean
CARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p query_engine_rust --lib precompute_operators → 87 passed, 0 failed
```
Depends on
ProjectASAP/asap_sketchlib#36 (force-pushed; head:
e473ccc).