Merged
Conversation
Collaborator
|
Please avoid functions like |
zzylol
reviewed
Mar 10, 2026
src/sketches/countmin.rs
Outdated
| let v = self.counts.query_one_counter(r, col); | ||
| if v.partial_cmp(&min) | ||
| .map(|o| o == Ordering::Less) | ||
| .unwrap_or(false) |
Contributor
There was a problem hiding this comment.
Min < v
V < min from Yancheng.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per changes suggested this comment:
We use sketchlib-rust in the ASAP query engine to aggregate floating-point telemetry metrics
(CPU %, request durations, etc.). Because CountMin<Vector2D, RegularPath> requires
S::Counter: Ord, and f64: !Ord (due to NaN), we currently round every metric value to the
nearest i64 before insertion, silently discarding fractional precision (0.7 → 0, 1.3 → 1).
Vector2D already satisfies MatrixStorage (T: Copy + AddAssign). with_dimensions and
from_storage already compile for f64. The only missing piece is insert_many / estimate for
the f64 counter path.
A single impl block for CountMin<Vector2D, RegularPath, H> that adds
insert_weighted(key, f64) and estimate_f64(key) -> f64, using f64::min() instead of the
Ord-dependent .min(). A CountMinF64 type alias is exported for convenience. No existing
API is changed.