Ionic References and Authentication#1
Merged
bryce13950 merged 2 commits intomainfrom Mar 28, 2024
Merged
Conversation
bryce13950
reviewed
Mar 27, 2024
| margin: 0 6px 16px 6px; | ||
| --padding-start: 0; | ||
| ion-input { | ||
| color: var(--ion-color-medium); |
Contributor
There was a problem hiding this comment.
Probably need to do another find and replace, and probably want to get into the habit of doing it whenever you bring anything in
Contributor
|
A couple other things to wrap up. We are only going to have one sign in process, so we can probably flatten the "SignInEmail" into the "SignIn" directory. The sign up is also only ever going to have the one page, so the "SignUpStep" component can be eliminated, and anything useful in it can just be put in the page. After those two change, then I think this should be organized well, and ready to go for beginning CNH customizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Sign in and Sign out functionality. Removed all references to Ionic