Death Messages

[ProjectEdenBot]

PugaBear: The previous DeathMessages plugin was incompatible with a few of our plugins, had a fkn german api, and just overall sucked. I wanna re-write.

• Way to add custom death messages from ingame
  • Some way for players to submit ones for review
• Full entity type support (zombie vs zombie villager vs husk etc)
• Hide death messages if they are too fast, and per world options (hook into mvinv?)

[GriffinCodes]

https://minecraft.gamepedia.com/Death_messages

Ideas from other plugins:
DeathMessagesPrime - PlayerDeathMessages.yml
DeathMessages - config.yml
FunnyDeathMessages - messages.yml

[GriffinCodes]

@lexikiq Can you help me understand how I could use Adventure to start work on this? Or is this still blocked by McMMO bugs?

[GriffinCodes]

Also the death messages code could use some cleanup/refactoring

[qixils]

mcMMO no longer touches death messages, so no worries there. There's still some code for fixing its broken messages which could be removed, I'll do some spring cleaning on it later.

I'm on my phone right now, but from memory, you can cast PlayerDeathEvent#deathMessage to TranslatableComponent which has a method #key, this gives you a Key object which specifies a namespace ("minecraft") and a value ("death.fall.idk")

What we'd likely do is have a yml file like

death.fall:
- %s splatted on the ground
- R.I.P. %s's name

And then get a random string from the file using the key. Basically a map of strings to a list of strings.

I'm not sure if Adventure has a Component type that uses something like String.format besides TranslatableComponent (though from Fabric modding, I know it should be possible), so we may have to implement a custom solution for formatting arguments

[GriffinCodes]

Created Nexus/death-messages.yml with all available keys and their english defaults

[qixils]

Adventure unfortunately does not have a format-like component besides TranslatableComponent, we'll need to create our own system for that