Skip to content

Bugfix: segwit#10

Merged
ReverseControl merged 2 commits intoProjectFactor:mainfrom
patricklodder:bugfix/segwit
Jun 24, 2022
Merged

Bugfix: segwit#10
ReverseControl merged 2 commits intoProjectFactor:mainfrom
patricklodder:bugfix/segwit

Conversation

@patricklodder
Copy link
Copy Markdown
Collaborator

Fixes #6

Makes the miner segwit-compatible:

  1. Add witness commitment in Coinbase tx
  2. Take the txid field from getblocktemplate, not the hash

🥳

@patricklodder patricklodder added the bug Something isn't working label Jun 23, 2022
The classically encoded transaction hash is stored in the txid
field whereas the hash field contains the witness-encoded tx hash
@ReverseControl ReverseControl merged commit b6bcc0b into ProjectFactor:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR: ProcessNewBlock: AcceptBlock FAILED (bad-txnmrklroot, hashMerkleRoot mismatch)

2 participants