Feat/custom s3 headers#16
Merged
Merged
Conversation
… etc.) Add three ways to set extra HTTP headers on every S3 request, all of which are merged together: - [s3.extra_headers] in TOML config for non-secret inline headers - LOFT_EXTRA_HEADER_* env vars (underscores map to hyphens) - extraHeadersFile NixOS option for file-based secrets (sops-nix/agenix) Headers are injected via an SDK interceptor at the modify_before_transmit phase (after SigV4 signing), so auth proxy headers are consumed by the proxy before reaching the S3 endpoint without causing signature mismatches.
Dedicated NixOS VM test that sets up nginx as an auth proxy in front of Garage requiring a X-Loft-Auth header on port 3902. Tests all three header mechanisms: - inline [s3.extra_headers] config - LOFT_EXTRA_HEADER_* env vars - file-based (simulating NixOS extraHeadersFile) - negative test: no headers, nginx returns 403, paths not uploaded
The nginx auth proxy was changing the Host header when forwarding to Garage, breaking the AWS SigV4 signature validation. Added proxy_set_header Host $host:$server_port to preserve the original endpoint host:port so signatures match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.