This repository was archived by the owner on Jan 20, 2023. It is now read-only.
Add get cache and fixes. #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改善
オブジェクトからの値読み出し処理をキャッシュすることで大幅な高速化を実現した。
修正
パラメータからの変換処理の不具合
パラメータをそのまま代入する処理で、誤って一番最初の値がキャッシュされてしまう不具合を修正した。
並列実行時への対応
キャッシュに
HashMapを用いていたが、並列実行時にキャッシュへの登録処理が壊れる可能性が懸念されたため、ConcurrentMapのアトミック処理でputするように修正を行った。