Skip to content

visualize3d() makes training freeze when saving 3D previews due to incorrect PyVista off-screen timing#55

Merged
ATATC merged 1 commit intoProjectNeura:mainfrom
perctrix:fix/pyvista-offscreen-timing
Oct 8, 2025
Merged

visualize3d() makes training freeze when saving 3D previews due to incorrect PyVista off-screen timing#55
ATATC merged 1 commit intoProjectNeura:mainfrom
perctrix:fix/pyvista-offscreen-timing

Conversation

@perctrix
Copy link
Collaborator

@perctrix perctrix commented Oct 4, 2025

This pull request makes a focused improvement to the 3D visualization workflow in mipcandy/data/visualization.py. The main change ensures that when a screenshot is requested, the Plotter is created in off-screen mode, which is the correct way to capture screenshots without displaying a window.

Visualization update:

  • In the _visualize3d_with_pyvista function, the Plotter is now initialized with off_screen=True if a screenshot is requested, instead of setting p.off_screen after creation. This ensures proper off-screen rendering for screenshots.

fixed #54

@ATATC ATATC changed the title fixed off_screen pass timing visualize3d() makes training freeze when saving 3D previews due to incorrect PyVista off-screen timing Oct 8, 2025
@ATATC ATATC self-requested a review October 8, 2025 14:15
@ATATC ATATC added bug Something isn't working todo New task or assignment labels Oct 8, 2025
@ATATC ATATC added this to the 1.1.0 milestone Oct 8, 2025
Copy link
Contributor

@ATATC ATATC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Status Update

Thank you for your contribution to Project Neura and its related projects. We sincerely appreciate your interest in our work and your passion to enhance the community. Your feedback is deeply valuable to us.

This update means one or more of our team members have carefully reviewed the issue you addressed and the corresponding pull request you proposed. The status of your pull request is now changed to:

  • The suggestion/problem you raised has been investigated and determined to be non-existent or negligible
  • The suggestion/problem you raised has been noticed and verified
  • The corresponding solution/fix you proposed has been carefully evaluated, yet we have to reject it regretfully
  • The corresponding solution/fix you proposed has been carefully evaluated, yet pending changes before acceptance
  • The corresponding solution/fix you proposed has been carefully evaluated and will be merged shortly

Reasons behind This Decision

Good.

What to Expect Next

It will be merged shortly.

@ATATC ATATC merged commit b60eed6 into ProjectNeura:main Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working todo New task or assignment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

visualize3d() makes training freeze when saving 3D previews due to incorrect PyVista off-screen timing

2 participants