visualize3d() makes training freeze when saving 3D previews due to incorrect PyVista off-screen timing#55
Merged
ATATC merged 1 commit intoProjectNeura:mainfrom Oct 8, 2025
Conversation
visualize3d() makes training freeze when saving 3D previews due to incorrect PyVista off-screen timing
ATATC
approved these changes
Oct 8, 2025
Contributor
ATATC
left a comment
There was a problem hiding this comment.
Pull Request Status Update
Thank you for your contribution to Project Neura and its related projects. We sincerely appreciate your interest in our work and your passion to enhance the community. Your feedback is deeply valuable to us.
This update means one or more of our team members have carefully reviewed the issue you addressed and the corresponding pull request you proposed. The status of your pull request is now changed to:
- The suggestion/problem you raised has been investigated and determined to be non-existent or negligible
- The suggestion/problem you raised has been noticed and verified
- The corresponding solution/fix you proposed has been carefully evaluated, yet we have to reject it regretfully
- The corresponding solution/fix you proposed has been carefully evaluated, yet pending changes before acceptance
- The corresponding solution/fix you proposed has been carefully evaluated and will be merged shortly
Reasons behind This Decision
Good.
What to Expect Next
It will be merged shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a focused improvement to the 3D visualization workflow in
mipcandy/data/visualization.py. The main change ensures that when a screenshot is requested, thePlotteris created in off-screen mode, which is the correct way to capture screenshots without displaying a window.Visualization update:
_visualize3d_with_pyvistafunction, thePlotteris now initialized withoff_screen=Trueif a screenshot is requested, instead of settingp.off_screenafter creation. This ensures proper off-screen rendering for screenshots.fixed #54