Verify HMAC when decrypting received payloads. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanOS
requested review from
chichkanov,
coryhardman,
edricwb,
jagtejsodhi,
mattkula and
mhernand40
jagtejsodhi
approved these changes
Sep 29, 2022
mhernand40
approved these changes
Sep 29, 2022
lib/src/main/kotlin/org/walletconnect/impls/MoshiPayloadEncryption.kt
Outdated
Show resolved
Hide resolved
mattkula
reviewed
Sep 29, 2022
| val providedHmac = decode(encryptedPayload.hmac) | ||
|
|
||
| // verify hmac | ||
| with(HMac(SHA256Digest())) { |
There was a problem hiding this comment.
Would probably be nice of us to contribute this back to the main lib at some point. Maybe just create a cleaned up version to PR off of that library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification in this context means we calculate the HMAC ourselves from the data, IV, and key and compare it against the HMAC that was provided.
Added tests to ensure happy case encryption and decryption works as well as mutated data, iv, and hmac values.