Respect ERC1271

[sosoxuc]

Motivation

Allow ERC1271 orders

Solution

Offerer can be different from signer (e.g. contract wallet address)

[ryanio]

nice thanks, do you mind also adding a 1271 test to ensure it works and doesn't break in the future?

i think we would also need to skip the signOrder step when 1271?

[sosoxuc]

i think we would also need to skip the signOrder step when 1271?

Do we?
An EOA can sign the order and then it is checked inside 1271 contract

    address public signer;

    function isValidSignature(bytes32 hash_, bytes calldata signature_) external override view returns (bytes4) {
        address signer_ = hash_.recover(signature_);
        if (signer_ == signer) {
            return 0x1626ba7e;
        }
        return 0x00000000;
    }

[sosoxuc]

nice thanks, do you mind also adding a 1271 test to ensure it works and doesn't break in the future?

Sure, will do

[sosoxuc]

nice thanks, do you mind also adding a 1271 test to ensure it works and doesn't break in the future?

Added tests but I have side effect — https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/ECDSA.sol#L70 will reject compacted sig

I can revert that change in the code if you do not think that makes sense

[sosoxuc]

@ryanio

[ryanio]

a couple comments to resolve but otherwise looks great, thanks for doing!

[sosoxuc]

@ryanio applied all changes

[ryanio]

looks good, could you run npm run prettier:fix please

[sosoxuc]

@ryanio done